gyfora commented on code in PR #196:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/196#discussion_r867450242
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java:
##########
@@ -62,14 +66,20 @@ void updateForSpecReconciliationSuccess(
var clonedSpec = ReconciliationUtils.clone(spec);
AbstractFlinkSpec lastReconciledSpec =
reconciliationStatus.deserializeLastReconciledSpec();
+ boolean upgrading = false;
if (lastReconciledSpec != null && lastReconciledSpec.getJob() != null)
{
Long oldSavepointTriggerNonce =
lastReconciledSpec.getJob().getSavepointTriggerNonce();
clonedSpec.getJob().setSavepointTriggerNonce(oldSavepointTriggerNonce);
+ if (clonedSpec.getJob().getState() == JobState.RUNNING
Review Comment:
I would prefer to keep it this way for now as it's only a simple enum check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
