Tartarus0zm commented on code in PR #19656:
URL: https://github.com/apache/flink/pull/19656#discussion_r867688723
##########
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectITCase.java:
##########
@@ -807,6 +807,29 @@ public void testShowPartitions() throws Exception {
assertTrue(partitions.toString().contains("dt=2020-04-30
01:02:03/country=china"));
}
+ @Test
+ public void testStatementVariableSubstitution() {
+ // test system variable for substitution
+ System.setProperty("k1", "v1");
+ List<Row> result =
+ CollectionUtil.iteratorToList(
+ tableEnv.executeSql("select
'${system:k1}'").collect());
+ assertEquals("[+I[v1]]", result.toString());
+
+ // test env variable for substitution
+ String classPath = System.getenv("CLASSPATH");
Review Comment:
env `CLASSPATH ` maybe not exist, CI details [test
fail](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=35446&view=logs&j=fc5181b0-e452-5c8f-68de-1097947f6483&t=995c650b-6573-581c-9ce6-7ad4cc038461)
We should test for an environment variable that exists and an environment
variable that does not exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
