snuyanzin commented on code in PR #19667:
URL: https://github.com/apache/flink/pull/19667#discussion_r868914244
##########
flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/typeutils/RowDataSerializerTest.java:
##########
@@ -346,17 +169,22 @@ public void testCopy() {
}
@Test
- public void testWrongCopy() {
- thrown.expect(IllegalArgumentException.class);
- serializer.copy(new GenericRowData(serializer.getArity() + 1));
+ void testWrongCopy() {
+ assertThatThrownBy(() -> serializer.copy(new
GenericRowData(serializer.getArity() + 1)))
+ .isInstanceOf(IllegalArgumentException.class);
}
@Test
public void testWrongCopyReuse() {
Review Comment:
```suggestion
void testWrongCopyReuse() {
```
##########
flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/typeutils/RowDataSerializerTest.java:
##########
@@ -346,17 +169,22 @@ public void testCopy() {
}
@Test
- public void testWrongCopy() {
- thrown.expect(IllegalArgumentException.class);
- serializer.copy(new GenericRowData(serializer.getArity() + 1));
+ void testWrongCopy() {
+ assertThatThrownBy(() -> serializer.copy(new
GenericRowData(serializer.getArity() + 1)))
+ .isInstanceOf(IllegalArgumentException.class);
}
@Test
public void testWrongCopyReuse() {
Review Comment:
```suggestion
void testWrongCopyReuse() {
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
