alpreu commented on code in PR #19660:
URL: https://github.com/apache/flink/pull/19660#discussion_r870236939


##########
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java:
##########
@@ -723,11 +721,11 @@ public void testCassandraBatchPojoFormat() throws 
Exception {
 
         final List<? extends Pojo> pojos = 
writePojosWithOutputFormat(annotatedPojoClass);
         ResultSet rs = session.execute(injectTableName(SELECT_DATA_QUERY));
-        Assert.assertEquals(20, rs.all().size());
+        assertThat(rs.all()).hasSize(20);
 
         final List<? extends Pojo> result = 
readPojosWithInputFormat(annotatedPojoClass);
-        Assert.assertEquals(20, result.size());
-        assertThat(result, samePropertyValuesAs(pojos));
+        assertThat(result).hasSize(20);
+        assertThat(result).satisfies(matching(samePropertyValuesAs(pojos)));

Review Comment:
   There is this `usingRecursiveComparison` feature in AssertJ 
(https://stackoverflow.com/a/44781859) but sadly it only works correctly if 
both lists are ordered identically



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to