gyfora commented on code in PR #204:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/204#discussion_r870952754
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java:
##########
@@ -385,4 +386,12 @@ private Optional<String>
validateSpecChange(FlinkSessionJob sessionJob) {
return Optional.empty();
}
+
+ private Optional<String> validateServiceAccount(String serviceAccount) {
+ if (serviceAccount == null) {
+ return Optional.of(
+ "serviceAccount must be defined. If you use helm, its
value should be the same with the name of jobServiceAccount.");
Review Comment:
I think it would be better to say `spec.serviceAccount must be defined. ...`
so the user knows where exactly it's missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
