FuyaoLi2017 commented on code in PR #202:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/202#discussion_r872873594
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigManager.java:
##########
@@ -133,6 +135,19 @@ public Configuration getObserveConfig(FlinkDeployment
deployment) {
return getConfig(deployment.getMetadata(),
ReconciliationUtils.getDeployedSpec(deployment));
}
+ public Configuration getSessionJobObserveConfig(
+ FlinkDeployment deployment, FlinkSessionJob flinkSessionJob) {
+ Configuration sessionJobConfig = getObserveConfig(deployment);
+
+ // merge session job specific config
+ Map<String, String> sessionJobFlinkConfiguration =
+ flinkSessionJob.getSpec().getFlinkConfiguration();
+ if (sessionJobFlinkConfiguration != null &&
!sessionJobFlinkConfiguration.isEmpty()) {
+ sessionJobFlinkConfiguration.forEach(sessionJobConfig::setString);
Review Comment:
I guess the logic would be more straight forward if this config in
sessionJob directly overrides the parent config.
If we do the merging work. Then a user will need to check two CRs instead of
one to determine what are the actual headers that is applied during jar
fetching during debugging. It could a little bit confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
