morhidi commented on code in PR #215:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/215#discussion_r873107836
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/sessionjob/FlinkSessionJobReconciler.java:
##########
@@ -76,6 +78,24 @@ public void reconcile(FlinkSessionJob flinkSessionJob,
Context context) throws E
OperatorUtils.getSecondaryResource(
flinkSessionJob, context,
configManager.getOperatorConfiguration());
+ var labels = flinkSessionJob.getMetadata().getLabels();
+ if (labels == null) {
+ labels = new HashMap<>();
+ }
+ if (!flinkSessionJob
+ .getSpec()
+ .getDeploymentName()
+ .equals(labels.get(LABEL_SESSION_CLUSTER))) {
+ labels.put(LABEL_SESSION_CLUSTER,
flinkSessionJob.getSpec().getDeploymentName());
+ flinkSessionJob.getMetadata().setLabels(labels);
+ kubernetesClient
Review Comment:
Got it, but this is the first use case that we modify something else then
the status. We might need to reconsider this again. Updating the CR deep in the
stack sounds worse to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
