[ 
https://issues.apache.org/jira/browse/FLINK-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15443338#comment-15443338
 ] 

ASF GitHub Bot commented on FLINK-4521:
---------------------------------------

GitHub user mushketyk opened a pull request:

    https://github.com/apache/flink/pull/2431

    [FLINK-4521] Fix "Submit new Job" panel in development mode

    Submit panel was completely empty in the development mode. This happened 
because client-side code sent AJAX requests to a development HTTP server 
(`localhost:3000`) and not to the the JobServer (`localhost:8081`) and 
development server rejected all AJAX requests.
    
    To fix the issue I did the following:
    
    - Updated `server.js` to pass both GET and POST requests to the JobServer 
(`localhost:8081`)
    - Changed all AJAX requests to use development HTTP server
    - Added a helper function to build a correct URL for both dev and prod modes
    
    Also, it seems that CoffeeScript and JavaScript code were out of sync in 
the `master`, so this PR contains a significant number of changes to `index.js`.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira 
title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the 
JIRA id)
    
    - [x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis 
build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mushketyk/flink fix-submit

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2431.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2431
    
----
commit 8b4ac3453bdae08c9f59594dfaf529026fa7e1d5
Author: Ivan Mushketyk <ivan.mushke...@gmail.com>
Date:   2016-08-28T11:04:12Z

    [FLINK-4521]  Fix Submit panel in development mode

commit 406512b219738a721911f7709e532111c35e67fa
Author: Ivan Mushketyk <ivan.mushke...@gmail.com>
Date:   2016-08-28T11:36:00Z

    [FLINK-4521] Add utils.jobServerUrl helper method

----


> Fix "Submit new Job" panel in development mode
> ----------------------------------------------
>
>                 Key: FLINK-4521
>                 URL: https://issues.apache.org/jira/browse/FLINK-4521
>             Project: Flink
>          Issue Type: Bug
>          Components: Webfrontend
>            Reporter: Ivan Mushketyk
>            Assignee: Ivan Mushketyk
>
> If web frontend is started in the development mode, "Submit new Job" panel is 
> empty.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to