masteryhx commented on code in PR #19701:
URL: https://github.com/apache/flink/pull/19701#discussion_r873506503
##########
docs/layouts/shortcodes/generated/rocksdb_native_metric_configuration.html:
##########
@@ -26,6 +26,18 @@
<td>Boolean</td>
<td>Monitor block cache capacity.</td>
</tr>
+ <tr>
Review Comment:
We may also need to add some descriptions about the new statistics in the
"RocksDB Native Metrics" module of "config.md".
As you could see current content: "The metrics here are scoped to the
operators and then further broken down by column family;".
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricOptions.java:
##########
@@ -227,11 +241,77 @@ public class RocksDBNativeMetricOptions implements
Serializable {
ConfigOptions.key(METRICS_COLUMN_FAMILY_AS_VARIABLE_KEY)
.booleanType()
.defaultValue(false)
- .withDescription("Whether to expose the column family as a
variable.");
+ .withDescription(
+ "Whether to expose the column family as a variable
for RocksDB property based metrics.");
+
+ //
--------------------------------------------------------------------------------------------
+ // RocksDB statistics based metrics, report at database level
+ //
--------------------------------------------------------------------------------------------
+
+ public static final ConfigOption<Boolean> MONITOR_BLOCK_CACHE_HIT =
Review Comment:
Could we also create a new class called "RocksDBStatistics" and use it just
like "RocksDBProperty" ?
Maybe it could be clearer to me. WDYT?
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBNativeMetricOptions.java:
##########
@@ -506,13 +622,21 @@ public Collection<String> getProperties() {
return Collections.unmodifiableCollection(properties);
}
+ public Collection<TickerType> getMonitorTickerTypes() {
Review Comment:
nit: add comments just like getProperties.
ditto: isStatisticsEnabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
