fapaul commented on code in PR #19628:
URL: https://github.com/apache/flink/pull/19628#discussion_r874577453


##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkBuilderTest.java:
##########
@@ -77,6 +77,15 @@ public void testPropertyHandling() {
                     assertEquals("v1", p.get("k1"));
                     assertEquals("correct", p.get("k2"));
                 });
+
+        Properties testConf1 = new Properties();

Review Comment:
   It would be better to have a separate test case for this because it adds new 
functiontionality.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to