echauchot commented on code in PR #19680:
URL: https://github.com/apache/flink/pull/19680#discussion_r874497578
##########
flink-core/src/main/java/org/apache/flink/api/common/io/OutputFormat.java:
##########
@@ -71,9 +71,10 @@
* <p>When this method is called, the output format it guaranteed to be
opened.
*
* @param record The records to add to the output.
- * @throws IOException Thrown, if the records could not be added to to an
I/O problem.
+ * @throws Exception Thrown, if the records could not be added due to an
I/O problem or a
+ * timeout.
*/
- void writeRecord(IT record) throws IOException;
+ void writeRecord(IT record) throws Exception;
Review Comment:
As said in the other comment, I proposed this change as `tryAcquire` already
threw exceptions and `OutputFormat` is not user facing so I felt we could
change to a more generic exception throwing. But it is true that even if it is
not a user braking change, it is a source-compatibility breaking change. So if
you prefer I'll make `tryAcquire` throw an unchecked exception in both Sink and
OutputFormat so that we don't need to change the throw clause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
