Aitozi commented on code in PR #219:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/219#discussion_r875455510


##########
docs/content/docs/custom-resource/job-management.md:
##########
@@ -65,33 +66,38 @@ kubectl delete flinkdeployment my-deployment
 ```
 
 {{< hint danger >}}
-Deleting a deployment will remove all checkpoint and status information. 
Future deployments will from an empty state unless manually overriden by the 
user.
+Deleting a deployment will remove all checkpoint and status information. 
Future deployments will from an empty state unless manually overridden by the 
user.
 {{< /hint >}}
 
 ## Stateful and stateless application upgrades
 
-When the spec changes for a FlinkDeployment the running Application or Session 
cluster must be upgraded.
+When the spec changes for FlinkDeployment and FlinkSessionJob resources, the 
running application must be upgraded.
 In order to do this the operator will stop the currently running job (unless 
already suspended) and redeploy it using the latest spec and state carried over 
from the previous run for stateful applications.
 
 Users have full control on how state should be managed when stopping and 
restoring stateful applications using the `upgradeMode` setting of the JobSpec.
 
-Supported values:`stateless`, `savepoint`, `last-state`
+Supported values: `stateless`, `savepoint`, `last-state`
 
 The `upgradeMode` setting controls both the stop and restore mechanisms as 
detailed in the following table:
 
-| | Stateless | Last State | Savepoint |
-| ---- | ---------- | ---- | ---- |
-| Config Requirement | None | Checkpointing & Kubernetes HA Enabled | 
Savepoint directory defined |
-| Job Status Requirement | None* | None* | Job Running |
-| Suspend Mechanism | Cancel / Delete | Delete Flink deployment (keep HA 
metadata) | Cancel with savepoint |
-| Restore Mechanism | Deploy from empty state | Recover last state using HA 
metadata | Restore From savepoint |
+|                        | Stateless               | Last State                
                 | Savepoint                              |
+|------------------------|-------------------------|--------------------------------------------|----------------------------------------|
+| Config Requirement     | None                    | Checkpointing & 
Kubernetes HA Enabled      | Checkpoint/Savepoint directory defined |
+| Job Status Requirement | None                    | HA metadata available     
                 | Job Running*                           |
+| Suspend Mechanism      | Cancel / Delete         | Delete Flink deployment 
(keep HA metadata) | Cancel with savepoint                  |
+| Restore Mechanism      | Deploy from empty state | Recover last state using 
HA metadata       | Restore From savepoint                 |
+| Production Use         | Not recommended         | Recommended               
                 | Recommended                            |
 
-*\*In general no update can be executed while a savepoint operation is in 
progress*
 
-The three different upgrade modes are intended to support different use-cases:
- - stateless: Stateless applications, prototyping
- - last-state: Suitable for most stateful production applications. Quick 
upgrades in any application state (even for failing jobs), does not require a 
healthy job. Requires Flink Kubernetes HA configuration (see example below).
- - savepoint: Suitable for forking, migrating applications. Requires a healthy 
running job as it requires a savepoint operation before shutdown.
+*\*When Kubernetes HA is enabled the `savepoint` upgrade mode may fall back to 
the `last-state` behaviour in cases where the job is in an unhealthy state.*
+
+The three  upgrade modes are intended to support different scenarios:

Review Comment:
   extra space



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to