lindong28 commented on code in PR #100:
URL: https://github.com/apache/flink-ml/pull/100#discussion_r875742089
##########
flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/datagenerator/InputDataGenerator.java:
##########
@@ -21,18 +21,18 @@
import org.apache.flink.ml.param.LongParam;
import org.apache.flink.ml.param.Param;
import org.apache.flink.ml.param.ParamValidators;
-import org.apache.flink.ml.param.StringArrayParam;
+import org.apache.flink.ml.param.StringArrayArrayParam;
/** Interface for generating data as input table arrays. */
public interface InputDataGenerator<T extends InputDataGenerator<T>> extends
DataGenerator<T> {
Param<Long> NUM_VALUES =
new LongParam(
"numValues", "Number of data to be generated.", 10L,
ParamValidators.gt(0));
- Param<String[]> COL_NAMES =
- new StringArrayParam(
+ Param<String[][]> COL_NAMES =
+ new StringArrayArrayParam(
"colNames",
- "An array of common-separated strings representing field
names of data tables.",
+ "A 2D array of strings. Each string array element
represents the column names of a data table.",
Review Comment:
nits: `the column names` -> `a column name`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
