[
https://issues.apache.org/jira/browse/FLINK-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15445335#comment-15445335
]
ASF GitHub Bot commented on FLINK-4517:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2428
I am a bit cautious with such changes. There is no necessity to change the
code, it only looses history, and there is always a slight risk of a new bug
appearing.
Some of the styles you are adjusting were actually good as they were
before. For example, I personally very much prefer to always call Java Methods
always with Parenthesis, since they are always defined with parenthesis.
How about we just update code style on the fly in the parts we touch
anyways?
> scala code refactoring
> ----------------------
>
> Key: FLINK-4517
> URL: https://issues.apache.org/jira/browse/FLINK-4517
> Project: Flink
> Issue Type: Improvement
> Reporter: shijinkui
> Priority: Minor
>
> such as:
> 1. case class does't need `new`
> 2. case block does't need `{ ... }`
> 3. match-case instead of isInstanceOf
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
