yunfengzhou-hub commented on code in PR #97: URL: https://github.com/apache/flink-ml/pull/97#discussion_r876690459
########## flink-ml-iteration/src/main/java/org/apache/flink/iteration/datacache/nonkeyed/Segment.java: ########## @@ -18,38 +18,49 @@ package org.apache.flink.iteration.datacache.nonkeyed; +import org.apache.flink.api.common.typeutils.TypeSerializer; import org.apache.flink.core.fs.Path; +import java.io.IOException; import java.io.Serializable; +import java.util.List; import java.util.Objects; -/** A segment represents a single file for the cache. */ +/** A segment contains the information about a cache unit. */ Review Comment: This class contains all information about a cache unit, no matter the cache is on disk, in memory, or both. I'll modify the doc and the api to improve its readability. ########## flink-ml-iteration/src/main/java/org/apache/flink/iteration/datacache/nonkeyed/Segment.java: ########## @@ -18,38 +18,49 @@ package org.apache.flink.iteration.datacache.nonkeyed; +import org.apache.flink.api.common.typeutils.TypeSerializer; import org.apache.flink.core.fs.Path; +import java.io.IOException; import java.io.Serializable; +import java.util.List; import java.util.Objects; -/** A segment represents a single file for the cache. */ +/** A segment contains the information about a cache unit. */ Review Comment: This class contains all information about a cache unit, no matter the cache is on disk, in memory, or both. I'll modify the doc and the api to improve its readability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
