openinx commented on code in PR #126:
URL: https://github.com/apache/flink-table-store/pull/126#discussion_r876960731
##########
flink-table-store-connector/src/test/java/org/apache/flink/table/store/connector/FileStoreTableITCase.java:
##########
@@ -58,4 +63,18 @@ private void prepareEnv(TableEnvironment env, String path) {
}
protected abstract List<String> ddl();
+
+ protected List<Row> sql(String query, Object... args) {
+ return sql(true, query, args);
+ }
+
+ protected List<Row> sql(boolean batch, String query, Object... args) {
Review Comment:
Let's just name it `batchSql`, the prefix `execute` is a relatively obvious
semantics, and executing sql is a quite frequent method. Let's use `batchSql`
to keep this name a bit shorter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
