gyfora commented on code in PR #229:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/229#discussion_r877748770
##########
tools/releasing/update_branch_version.sh:
##########
@@ -64,7 +64,11 @@ perl -pi -e "s#^ENV OPERATOR_VERSION=.*#ENV
OPERATOR_VERSION=${NEW_VERSION}#" Do
# change Helm chart version info
perl -pi -e "s#^version: .*#version: ${NEW_VERSION}#"
helm/flink-kubernetes-operator/Chart.yaml
perl -pi -e "s#^appVersion: .*#appVersion: ${NEW_VERSION}#"
helm/flink-kubernetes-operator/Chart.yaml
-
+#change version of documentation
+cd docs
+perl -pi -e "s#^ Version = .*# Version = \"${NEW_VERSION}\"#" config.toml
+perl -pi -e "s#^ VersionTitle = .*# VersionTitle = \"${NEW_VERSION}\"#"
config.toml
+cd ..
Review Comment:
I don't think we should do this here. The docs are built from the release
branch (which otherwise has the snapshot version). I think we need to update
the config manually when cutting the release branch like you did
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
