[GitHub] [flink] luoyuxia commented on a diff in pull request #19562: [FLINK-27304][hive] Calcite's varbinary type should be converted to Hive's binary type.

Fri, 20 May 2022 03:44:17 -0700 


luoyuxia commented on code in PR #19562:
URL: https://github.com/apache/flink/pull/19562#discussion_r877701927


##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/copy/HiveParserTypeConverter.java:
##########
@@ -289,6 +289,7 @@ private static TypeInfo convertPrimitiveType(RelDataType 
rType) {
             case INTERVAL_SECOND:
                 return hiveShim.getIntervalDayTimeTypeInfo();
             case BINARY:
+            case VARBINARY:
                 return TypeInfoFactory.binaryTypeInfo;

Review Comment:
   Thanks for your reminer. 
   Yes, we also should all them. And we have also a jira for 
TIME_WITH_LOCAL_TIME_ZONE 
[FLINK-23224](https://issues.apache.org/jira/browse/FLINK-23224).
   I will support it in other pr.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to