dianfu commented on code in PR #19775:
URL: https://github.com/apache/flink/pull/19775#discussion_r879373137
##########
docs/content/docs/connectors/datastream/pulsar.md:
##########
@@ -169,13 +224,32 @@ you can use the predefined `PulsarDeserializationSchema`.
Pulsar connector provi
PulsarDeserializationSchema.pulsarSchema(Schema, Class, Class);
```
- Decode the message by using Flink's `DeserializationSchema`
+ {{< tabs "pulsar-deserializer-deserialization-schema" >}}
+ {{< tab "Java" >}}
```java
PulsarDeserializationSchema.flinkSchema(DeserializationSchema);
```
+ {{< /tab >}}
+ {{< tab "Python" >}}
+ ```python
+ PulsarDeserializationSchema.flink_schema(DeserializationSchema)
+ ```
+ {{< /tab >}}
+ {{< /tabs >}}
+
- Decode the message by using Flink's `TypeInformation`
+ {{< tabs "pulsar-deserializer-type-information" >}}
+ {{< tab "Java" >}}
```java
PulsarDeserializationSchema.flinkTypeInfo(TypeInformation, ExecutionConfig);
```
+ {{< /tab >}}
+ {{< tab "Python" >}}
+ ```python
+ PulsarDeserializationSchema.flink_type_info(TypeInformation, ExecutionConfig)
Review Comment:
Currently, it's not possible to create ExecutionConfig in Python and so I
have merged one
commit(https://github.com/apache/flink/commit/73590f432d8dc4cd53f0357025e250a823e6b857)
to allow create PulsarDeserializationSchema without specifying
ExecutionConfig. So what about suggest users to use
`PulsarDeserializationSchema.flink_type_info(TypeInformation)` here?
##########
docs/content/docs/connectors/datastream/pulsar.md:
##########
@@ -335,12 +486,27 @@ job, the Pulsar source periodically discover new
partitions under a provided
topic-partition subscription pattern. To enable partition discovery, you can
set a non-negative value for
the `PulsarSourceOptions.PULSAR_PARTITION_DISCOVERY_INTERVAL_MS` option:
+{{< tabs "pulsar-dynamic-partition-discovery" >}}
+{{< tab "Java" >}}
+
```java
// discover new partitions per 10 seconds
PulsarSource.builder()
.setConfig(PulsarSourceOptions.PULSAR_PARTITION_DISCOVERY_INTERVAL_MS,
10000);
```
+{{< /tab >}}
+{{< tab "Python" >}}
+
+```python
+# discover new partitions per 10 seconds
+PulsarSource.builder()
+ .set_config(PulsarSourceOptions.PULSAR_PARTITION_DISCOVERY_INTERVAL_MS,
10000)
Review Comment:
```suggestion
.set_config("pulsar.source.partitionDiscoveryIntervalMs", 10000)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
