rkhachatryan commented on code in PR #19448:
URL: https://github.com/apache/flink/pull/19448#discussion_r880787079
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistry.java:
##########
@@ -57,13 +58,30 @@ public interface SharedStateRegistry extends AutoCloseable {
*/
StreamStateHandle registerReference(
SharedStateRegistryKey registrationKey, StreamStateHandle state,
long checkpointID);
+
+ /**
+ * Register a reference to the given checkpoint in the registry.
+ *
+ * @param checkpoint which is completed
+ */
+ void registerCompletedCheckpoint(CompletedCheckpoint checkpoint);
Review Comment:
Wouldn't it be more clear to pass the checkpoint to
`unregisterUnusedStateAndCheckpoint` (and remove this method)?
That would require changing `Optional<Checkpoint>` to `List` in
`StandaloneCompletedCheckpointStore.addCheckpointAndSubsumeOldestOne`, but
that shouldn't be an issue.
edit:
the methods make sense if we introduce `SubsumedCheckpointStore`/Cleaner as
discussed offline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
