[ 
https://issues.apache.org/jira/browse/FLINK-27579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541923#comment-17541923
 ] 

Liu commented on FLINK-27579:
-----------------------------

[~wangyang0918] Yes, you are right. The method getEffectiveConfiguration is not 
called for some actions, like stop and cancel. Although most of configs take 
effect when the job starts, there exist some configs in other actions. The 
config clientTimeout is just one.

In this case, I think that the simplest way to fix is to fetch clientTimeout 
from the effectiveConfiguration. If we consider more, all the actions should 
get configs from effectiveConfiguration instead of the initial configuration in 
the constructor. 

What do you think?

 

> The param client.timeout can not be set by dynamic properties when stopping 
> the job 
> ------------------------------------------------------------------------------------
>
>                 Key: FLINK-27579
>                 URL: https://issues.apache.org/jira/browse/FLINK-27579
>             Project: Flink
>          Issue Type: Improvement
>          Components: Client / Job Submission
>    Affects Versions: 1.16.0
>            Reporter: Liu
>            Priority: Major
>              Labels: pull-request-available
>
> The default client.timeout value is one minute which may be too short when 
> stop-with-savepoint for big state jobs.
> When we stop the job by dynamic properties(-D or -yD for yarn), the 
> client.timeout is not effective.
> From the code, we can see that the dynamic properties are only effect for run 
> command. We should support it for stop command.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to