akalash commented on PR #19702: URL: https://github.com/apache/flink/pull/19702#issuecomment-1137472221
It is not really that way. jobManagerTaskRestore -> InflightDataRescalingDescriptor -> Virtual Channel is the current logic that says that we need Virtual Channel only if we need rescaling(which is true). I actually haven't changed anything there. And if something changes that the rescaling feature will be entirely broken. But the condition `we need rescaling` is incorrect right now and it is exactly what I have fixed. So I tried to say that the current problem is not about missing Virtual Channel the current problem is that we determine rescaling incorrectly(we think that we don't want to rescale but in reality we want). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
