fredia commented on code in PR #19448:
URL: https://github.com/apache/flink/pull/19448#discussion_r881847122
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistry.java:
##########
@@ -57,13 +63,30 @@ public interface SharedStateRegistry extends AutoCloseable {
*/
StreamStateHandle registerReference(
SharedStateRegistryKey registrationKey, StreamStateHandle state,
long checkpointID);
+
/**
* Unregister state that is not referenced by the given checkpoint ID or
any newer.
*
* @param lowestCheckpointID which is still valid
*/
+ @VisibleForTesting
void unregisterUnusedState(long lowestCheckpointID);
Review Comment:
Delete it. It is used by
`AbstractCompleteCheckpointStore#unregisterUnusedState()`, and
`AbstractCompleteCheckpointStore#unregisterUnusedState()` is used by
`EmbeddedCompletedCheckpointStore#removeOldestCheckpoint()`, which is used for
testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
