gyfora commented on code in PR #247:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/247#discussion_r884250202
##########
docs/content/docs/operations/configuration.md:
##########
@@ -50,11 +50,50 @@ defaultConfiguration:
To learn more about metrics and logging configuration please refer to the
dedicated [docs page]({{< ref "docs/operations/metrics-logging" >}}).
+## Dynamic Operator Configuration
+
+The Kubernetes operator supports dynamic config changes through the operator
ConfigMaps. Dynamic operator configuration can be enabled by setting
`kubernetes.operator.dynamic.config.enabled` to true. Time interval for
checking dynamic config changes is specified by
`kubernetes.operator.dynamic.config.check.interval` of which default value is 5
minutes.
+
+Verify whether dynamic operator configuration updates is enabled via the
`deploy/flink-kubernetes-operator` log has:
+
+```
+2022-05-28 13:08:29,222 o.a.f.k.o.c.FlinkConfigManager [INFO ] Enabled dynamic
config updates, checking config changes every PT5M
+```
+
+For example, the default configuration of `flink-conf.yaml` in the
`defaultConfiguration` section of the Helm `values.yaml` file is as follows:
+
+```
+defaultConfiguration:
+ create: true
+ append: false
+ flink-conf.yaml: |+
+ # Flink Config Overrides
+ kubernetes.operator.reconciler.reschedule.interval: 60 s
+```
+
+When the interval for the controller to reschedule the reconcile process need
to change with 30 seconds, `kubernetes.operator.reconciler.reschedule.interval`
in the `defaultConfiguration` section can directly change to 30s:
+
+```
+defaultConfiguration:
+ create: true
+ append: false
+ flink-conf.yaml: |+
+ # Flink Config Overrides
+ kubernetes.operator.reconciler.reschedule.interval: 30 s
+```
Review Comment:
I think this is not a good example because if you try to update the
configmap through the Helm chart (using helm-upgrade) nothing will happen
because helm only checks if the configmap is present. It will not update it.
We should simply show an example of editing the configmap directly.
##########
docs/content/docs/operations/configuration.md:
##########
@@ -50,11 +50,50 @@ defaultConfiguration:
To learn more about metrics and logging configuration please refer to the
dedicated [docs page]({{< ref "docs/operations/metrics-logging" >}}).
+## Dynamic Operator Configuration
+
+The Kubernetes operator supports dynamic config changes through the operator
ConfigMaps. Dynamic operator configuration can be enabled by setting
`kubernetes.operator.dynamic.config.enabled` to true. Time interval for
checking dynamic config changes is specified by
`kubernetes.operator.dynamic.config.check.interval` of which default value is 5
minutes.
Review Comment:
We should say that it is enabled by default, and can be **disabled** with
the config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
