gyfora commented on code in PR #244:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/244#discussion_r884251881
##########
flink-kubernetes-webhook/pom.xml:
##########
@@ -36,6 +36,19 @@ under the License.
<groupId>org.apache.flink</groupId>
<artifactId>flink-kubernetes-operator</artifactId>
<version>${project.version}</version>
+ <scope>provided</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>io.javaoperatorsdk</groupId>
+ <artifactId>operator-framework-framework-core</artifactId>
+ <version>${operator.sdk.admission-controller.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>*</groupId>
Review Comment:
I think the slightly cleaner approach here would be to remove the exclude
all and explicitly include artifacts in the shade plugin:
```
<configuration>
<artifactSet>
<includes>
<include>io.javaoperatorsdk:operator-framework-framework-core</include>
</includes>
</artifactSet>
<transformers combine.children="append">
<transformer
implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
<mainClass>org.apache.flink.kubernetes.operator.admission.FlinkOperatorWebhook</mainClass>
</transformer>
</transformers>
</configuration>
```
This will be more flexible in the future when we need to add 1-2 extra
packages here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
