[ 
https://issues.apache.org/jira/browse/FLINK-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15448411#comment-15448411
 ] 

ASF GitHub Bot commented on FLINK-4499:
---------------------------------------

Github user rmetzger commented on the issue:

    https://github.com/apache/flink/pull/2422
  
    I've compared the build time of the pull request with a recent build on 
master, and it seems that the impact on the build time is pretty big (right is 
with findbugs):
    
![image](https://cloud.githubusercontent.com/assets/89049/18081134/dabb7974-6e98-11e6-8093-059efbe04eb3.png)
    
    On my local machine, the build time looks like this:
    +findbugs: 15:47 min
    -findbugs: 08:24 min
    
    On travis, our builds would be again pretty close to the 2 hours limit with 
this change.
    Maybe we can move the findbugs plugin into a separate profile and run it in 
a special build on travis?
    I'll try that out and report back.



> Introduce findbugs maven plugin
> -------------------------------
>
>                 Key: FLINK-4499
>                 URL: https://issues.apache.org/jira/browse/FLINK-4499
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Ted Yu
>
> As suggested by Stephan in FLINK-4482, this issue is to add 
> findbugs-maven-plugin into the build process so that we can detect lack of 
> proper locking and other defects automatically.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to