zeus1ammon commented on code in PR #246:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/246#discussion_r886158707
##########
helm/flink-kubernetes-operator/templates/flink-operator.yaml:
##########
@@ -34,6 +34,12 @@ spec:
{{- include "flink-operator.selectorLabels" . | nindent 8 }}
annotations:
kubectl.kubernetes.io/default-container: {{ .Chart.Name }}
+ {{- $keyExist := .Values.operatorPodDeployment | default dict -}}
Review Comment:
I could go with .Values.operatorPodDeployment.annotations as well, . but in
that case, we need to have the following in the values.yaml, even if we intend
not to pass any new annotations.
operatorPodDeployment:
annotations: {}
Approach that I went with, is to keep "operatorPodDeployment" completely
optional, as the chart will not fail, even if we don't pass
"operatorPodDeployment" in the values.yaml file.
If we desire the former approach, I can change it accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
