godfreyhe commented on code in PR #19286:
URL: https://github.com/apache/flink/pull/19286#discussion_r888967055
##########
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvRowDataDeserializationSchema.java:
##########
@@ -206,6 +235,6 @@ public int hashCode() {
csvSchema.getArrayElementSeparator(),
csvSchema.getQuoteChar(),
csvSchema.getEscapeChar(),
- csvSchema.getNullValue());
+ Arrays.hashCode(csvSchema.getNullValue()));
Review Comment:
why we need to change this ?
##########
flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvFormatFactoryTest.java:
##########
@@ -227,6 +228,24 @@ public void testInvalidIgnoreParseError() {
createTableSink(SCHEMA, options);
}
+ @Test
+ public void testProjectionPushdown() throws IOException {
Review Comment:
could you add more complex test cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
