[
https://issues.apache.org/jira/browse/FLINK-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15450761#comment-15450761
]
ASF GitHub Bot commented on FLINK-4516:
---------------------------------------
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2427
@mxm , thanks for your review. I had change the code based on your advice,
the changes are following:
1. move all code in the methods handleGrantLeadership, revokeLeadership,
onLeaderElectionError to ResourceManagerLeaderContender class from
ResourceManager
2. change getAddress method in ResourceManagerLeaderContender.
3. change callAsync method in TestingSerialRpcService, now it will be
executed immediately rather than wait for some time.
4. change TestingSerialRpcService to extend RpcService directly rather than
TestingRpcService.
> ResourceManager leadership election
> -----------------------------------
>
> Key: FLINK-4516
> URL: https://issues.apache.org/jira/browse/FLINK-4516
> Project: Flink
> Issue Type: Sub-task
> Components: Cluster Management
> Reporter: zhangjing
> Assignee: zhangjing
>
> 1. When a resourceManager is started, it starts the leadership election
> service first and take part in contending for leadership
> 2. Every resourceManager contains a ResourceManagerLeaderContender, when it
> is granted leadership, it will start SlotManager and other main components.
> when it is revoked leadership, it will stop all its components and clear
> everything.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
