zhuzhurk commented on code in PR #19653:
URL: https://github.com/apache/flink/pull/19653#discussion_r891870085
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java:
##########
@@ -296,12 +300,36 @@ private void handleTaskFailure(
final long timestamp = System.currentTimeMillis();
setGlobalFailureCause(error, timestamp);
notifyCoordinatorsAboutTaskFailure(executionVertexId, error);
+ Throwable finalError =
Review Comment:
This should happen before the above `setGlobalFailureCause`.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java:
##########
@@ -296,12 +300,36 @@ private void handleTaskFailure(
final long timestamp = System.currentTimeMillis();
Review Comment:
`handleGlobalFailure` needs this change as well.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java:
##########
@@ -296,12 +300,36 @@ private void handleTaskFailure(
final long timestamp = System.currentTimeMillis();
setGlobalFailureCause(error, timestamp);
notifyCoordinatorsAboutTaskFailure(executionVertexId, error);
+ Throwable finalError =
+ maybeTranslateCachedIntermediateDataSetException(error,
executionVertexId);
final FailureHandlingResult failureHandlingResult =
executionFailureHandler.getFailureHandlingResult(
- executionVertexId, error, timestamp);
+ executionVertexId, finalError, timestamp);
maybeRestartTasks(failureHandlingResult);
}
+ private Throwable maybeTranslateCachedIntermediateDataSetException(
Review Comment:
maybe `maybeTranslateToCachedIntermediateDataSetException`?
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java:
##########
@@ -296,12 +300,36 @@ private void handleTaskFailure(
final long timestamp = System.currentTimeMillis();
setGlobalFailureCause(error, timestamp);
notifyCoordinatorsAboutTaskFailure(executionVertexId, error);
+ Throwable finalError =
Review Comment:
And maybe rename `finalError` to `revisedError` to make it better self
explanatory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
