dianfu commented on code in PR #19918:
URL: https://github.com/apache/flink/pull/19918#discussion_r893076443
##########
docs/content/docs/dev/table/common.md:
##########
@@ -411,6 +411,28 @@ tableEnv.createTemporaryView("`example.View`", table)
tableEnv.createTemporaryView("other_catalog.other_database.exampleView", table)
```
{{< /tab >}}
+{{< tab "Python" >}}
Review Comment:
Should also update the Chinese page which is located under directory
`docs.zh`
##########
docs/content/docs/dev/table/common.md:
##########
@@ -411,6 +411,28 @@ tableEnv.createTemporaryView("`example.View`", table)
tableEnv.createTemporaryView("other_catalog.other_database.exampleView", table)
```
{{< /tab >}}
+{{< tab "Python" >}}
Review Comment:
Could we also add Python example for the following example:
https://nightlies.apache.org/flink/flink-docs-release-1.15/docs/dev/table/common/#connector-tables
##########
docs/content/docs/dev/table/common.md:
##########
@@ -411,6 +411,28 @@ tableEnv.createTemporaryView("`example.View`", table)
tableEnv.createTemporaryView("other_catalog.other_database.exampleView", table)
```
{{< /tab >}}
+{{< tab "Python" >}}
+```python
+# get a TableEnvironment
+t_env = StreamTableEnvironment.create(...)
Review Comment:
```suggestion
t_env = TableEnvironment.create(...)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
