JingsongLi commented on code in PR #150:
URL: https://github.com/apache/flink-table-store/pull/150#discussion_r893484862
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/table/ChangelogWithKeyFileStoreTable.java:
##########
@@ -103,7 +115,27 @@ public TableScan newScan(boolean incremental) {
return new TableScan(scan, schema, store.pathFactory()) {
@Override
protected void withNonPartitionFilter(Predicate predicate) {
- scan.withValueFilter(predicate);
+ // currently we can only perform filter push down on keys
+ // consider this case:
+ // data file 1: insert key = a, value = 1
+ // data file 2: update key = a, value = 2
+ // filter: value = 1
+ // if we perform filter push down on values, data file 1 will
be chosen, but data
+ // file 2 will be ignored, and the final result will be key =
a, value = 1 while the
+ // correct result is an empty set
Review Comment:
Add a TODO to support value filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
