Aitozi commented on code in PR #227:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/227#discussion_r894101067
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkUtils.java:
##########
@@ -278,4 +280,10 @@ public static boolean
isKubernetesHAActivated(Configuration configuration) {
public static boolean clusterShutdownDisabled(FlinkDeploymentSpec spec) {
return spec.getFlinkVersion().isNewerVersionThan(FlinkVersion.v1_14);
}
+
+ public static int getNumTaskManagers(Configuration conf) {
+ int parallelism = conf.get(CoreOptions.DEFAULT_PARALLELISM);
+ int taskSlots = conf.get(TaskManagerOptions.NUM_TASK_SLOTS);
+ return (parallelism + taskSlots - 1) / taskSlots;
Review Comment:
IMO, it should be `parallelism / taskSlots`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
