mayuehappy commented on code in PR #19259:
URL: https://github.com/apache/flink/pull/19259#discussion_r894137179
##########
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/CepOperator.java:
##########
@@ -417,6 +405,9 @@ private void processEvent(NFAState nfaState, IN event, long
timestamp) throws Ex
timestamp,
afterMatchSkipStrategy,
cepTimerService);
+ if (nfa.getWindowTime() > 0 && nfaState.isNewStartPartialMatch()) {
+ registerTimer(timestamp + nfa.getWindowTime());
Review Comment:
@dianfu thank a lot for the review . I found that I did miss this line. So I
made the following changes:
1. I notice that the processing timer registered in the previous code is
`timerService.currentProcessingTime() + 1`, so I modified it a bit.
2. As your suggestion add `advanceTime` in `onProcessingTime`. But I prefer
to use `timerService.currentProcessingTime()`
And I have updated the PR ,PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
