gyfora commented on code in PR #19825:
URL: https://github.com/apache/flink/pull/19825#discussion_r894241922


##########
flink-runtime/src/main/java/org/apache/flink/runtime/security/token/KerberosDelegationTokenManager.java:
##########
@@ -173,27 +274,95 @@ void startTGTRenewal() throws IOException {
                                                     LOG.warn("Error while 
renewing TGT", e);
                                                 }
                                             }),
-                            tgtRenewalPeriod,
+                            0,
                             tgtRenewalPeriod,
                             TimeUnit.MILLISECONDS);
-            LOG.debug("TGT renewal task started and reoccur in {} ms", 
tgtRenewalPeriod);
+            LOG.info("TGT renewal task started and reoccur in {} ms", 
tgtRenewalPeriod);
         } else {
-            LOG.debug("TGT renewal task not started");
+            LOG.info("TGT renewal task not started");
         }
     }
 
+    @VisibleForTesting
     void stopTGTRenewal() {
         if (tgtRenewalFuture != null) {
             tgtRenewalFuture.cancel(true);
             tgtRenewalFuture = null;
         }
     }
 
+    @VisibleForTesting
+    void startTokensUpdate() {
+        try {
+            LOG.info("Starting tokens update task");

Review Comment:
   Should we check `isLoginPossible` before starting this logic?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to