leonardBang commented on code in PR #19741:
URL: https://github.com/apache/flink/pull/19741#discussion_r894249878
##########
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/AbstractJdbcCatalog.java:
##########
@@ -144,19 +144,23 @@ public String getBaseUrl() {
// ------ retrieve PK constraint ------
protected Optional<UniqueConstraint> getPrimaryKey(
- DatabaseMetaData metaData, String schema, String table) throws
SQLException {
+ DatabaseMetaData metaData, String catalog, String schema, String
table)
Review Comment:
The `catalog` meaning in Database(MySQL) is different with `catalog` meaning
in Flink SQL, we'd better make it more clear, we can refer other popular
projects as well. Eg we can use `database` as parameter name and add proper
java doc, because `database` == `catalog` in Postgresql and MySQL 8.0.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
