echauchot opened a new pull request, #19935:
URL: https://github.com/apache/flink/pull/19935

   ## What is the purpose of the change
   
   Move OutputFormatBase to flink-core to offer flush mechanism to all output 
formats
   
   ## Brief change log
   
   Move OutputFormatBase from connectors-cassandra module to flink-core to 
offer flush mechanism to all output formats.
   Main change was to change (not yet public) send method signature so that it 
returns a `CompletionStage` and not a guava `ListenableFuture`. Implementers 
can chose their `CompletionStage` implementation as long as it implements 
`CompletionStage#toCompletableFuture()`
   
   
   ## Verifying this change
   
   
   This change is already covered by existing tests, such as 
OutputFormatBaseTest and CassandraConnectorITCase (for first implementation)
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? yes (not applicable / 
docs / JavaDocs / not documented)
     - If yes, how is the feature documented? javadocs
   
   R: @zentol  as discussed in the other PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to