salvalcantara commented on code in PR #19366:
URL: https://github.com/apache/flink/pull/19366#discussion_r894761263
##########
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java:
##########
@@ -184,6 +184,18 @@
return this;
}
+ /**
+ * Set the Kafka subscriber to use to discover new splits.
+ *
+ * @param kafkaSubscriber the {@link KafkaSubscriber} to use for split
discovery.
+ * @return this KafkaSourceBuilder.
+ */
+ public KafkaSourceBuilder<OUT> setKafkaSubscriber(KafkaSubscriber
kafkaSubscriber) {
+ ensureSubscriberIsNull("subscriber");
Review Comment:
I'd implement the same behaviour as in `setTopics` and `setTopicPattern`,
which use `ensureSubscriberIsNull` too. Maybe instead of `"subscriber"` I'd use
`"custom"` or something along these lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
