[GitHub] [flink] lsyldliu commented on a diff in pull request #19860: [FLINK-27658][table] FlinkUserCodeClassLoader expose addURL method to allow to register jar dynamically

Mon, 13 Jun 2022 02:56:38 -0700 


lsyldliu commented on code in PR #19860:
URL: https://github.com/apache/flink/pull/19860#discussion_r895539630


##########
flink-core/src/main/java/org/apache/flink/util/FlinkUserCodeClassLoader.java:
##########
@@ -67,4 +67,9 @@ protected Class<?> loadClassWithoutExceptionHandling(String 
name, boolean resolv
             throws ClassNotFoundException {
         return super.loadClass(name, resolve);
     }
+
+    @Override
+    public void addURL(URL url) {

Review Comment:
   Due to `SafetyNetWrapperClassLoader` and `URLClassLoader` are not in the 
same package, so SafetyNetWrapperClassLoader can not call the `addURL` directly.



##########
flink-core/src/main/java/org/apache/flink/util/FlinkUserCodeClassLoader.java:
##########
@@ -67,4 +67,9 @@ protected Class<?> loadClassWithoutExceptionHandling(String 
name, boolean resolv
             throws ClassNotFoundException {
         return super.loadClass(name, resolve);
     }
+
+    @Override
+    public void addURL(URL url) {

Review Comment:
   
![image](https://user-images.githubusercontent.com/17698589/173328950-772441bf-c6c8-49ca-82d8-2ede518b30d8.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to