zhuzhurk commented on PR #19946: URL: https://github.com/apache/flink/pull/19946#issuecomment-1154817846
> > > Maybe add a hotfix commit "Rework BinaryInputFormatTest to be based on AssertJ" first. And then add the new test using AssertJ. > > > > > > same as @zhuzhurk's previous suggestion, you should put the hotfix in the first commit, and then commit your changes and new tests follow it. > > Sorry, I don't quite understand this suggestion. Do you mean I should start a new PR to Rework BinaryInputFormatTest first? I mean that the hotfix commit happens first, and the commit of FLINK-28018 happens later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
