SteNicholas commented on code in PR #268:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/268#discussion_r896625394
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentController.java:
##########
@@ -81,59 +80,121 @@ public FlinkDeploymentController(
ReconcilerFactory reconcilerFactory,
ObserverFactory observerFactory,
MetricManager<FlinkDeployment> metricManager,
+ Metrics metrics,
StatusHelper<FlinkDeploymentStatus> statusHelper) {
this.configManager = configManager;
this.kubernetesClient = kubernetesClient;
this.validators = validators;
this.reconcilerFactory = reconcilerFactory;
this.observerFactory = observerFactory;
this.metricManager = metricManager;
+ this.metrics = metrics;
this.statusHelper = statusHelper;
}
@Override
public DeleteControl cleanup(FlinkDeployment flinkApp, Context context) {
Review Comment:
@morhidi, the `Metrics` should be integrated in the
`FlinkDeploymentController` and `FlinkSessionController`, like above
`Controller`. Any misunderstanding?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
