XComp commented on code in PR #19957:
URL: https://github.com/apache/flink/pull/19957#discussion_r897586518
##########
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveSchedulerTest.java:
##########
@@ -1080,10 +1053,10 @@ private Iterable<RootExceptionHistoryEntry>
runExceptionHistoryTests(
declarativeSlotPool,
createSlotOffersForResourceRequirements(
ResourceCounter.withResource(
- ResourceProfile.UNKNOWN,
numAvailableSlots)),
+ ResourceProfile.UNKNOWN,
PARALLELISM)),
taskManagerGateway);
});
- listener.waitForRunning();
+ taskManagerGateway.waitForSubmissions(4,
TestingUtils.infiniteDuration());
Review Comment:
can we add a comment here about why waiting for all subtasks here is
necessary due to checkpointing?
##########
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveSchedulerTest.java:
##########
@@ -1080,10 +1053,10 @@ private Iterable<RootExceptionHistoryEntry>
runExceptionHistoryTests(
declarativeSlotPool,
createSlotOffersForResourceRequirements(
ResourceCounter.withResource(
- ResourceProfile.UNKNOWN,
numAvailableSlots)),
+ ResourceProfile.UNKNOWN,
PARALLELISM)),
taskManagerGateway);
});
- listener.waitForRunning();
+ taskManagerGateway.waitForSubmissions(4,
TestingUtils.infiniteDuration());
Review Comment:
```suggestion
taskManagerGateway.waitForSubmissions(PARALLELISM,
TestingUtils.infiniteDuration());
```
We can remove the magic number here as well...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
