imaffe commented on code in PR #19973:
URL: https://github.com/apache/flink/pull/19973#discussion_r898643192
##########
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceBuilder.java:
##########
@@ -369,6 +373,18 @@ public <T extends OUT> PulsarSourceBuilder<T>
setDeserializationSchema(
return self;
}
+ /**
+ * Sets a {@link CryptoKeyReader}. Configure the key reader to be used to
decrypt the message
+ * payloads.
+ *
+ * @param cryptoKeyReader CryptoKeyReader object
+ * @return this PulsarSourceBuilder.
+ */
+ public PulsarSourceBuilder<OUT> setCryptoKeyReader(CryptoKeyReader
cryptoKeyReader) {
+ this.cryptoKeyReader = checkNotNull(cryptoKeyReader);
Review Comment:
Do we need to add e2e encryption in the documentation as well ? The
cryptoKeyReader contains private key, I think we need to let users know what is
the recommended/safe way to create a cryptoKeyReader~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
