luoyuxia commented on code in PR #19851:
URL: https://github.com/apache/flink/pull/19851#discussion_r898679763
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/utils/ScalarOperatorsTestBase.scala:
##########
@@ -67,8 +67,8 @@ abstract class ScalarOperatorsTestBase extends
ExpressionTestBase {
DataTypes.FIELD("f8", DataTypes.INT()),
DataTypes.FIELD("f9", DataTypes.INT()),
DataTypes.FIELD("f10", DataTypes.STRING()),
- DataTypes.FIELD("f11", DataTypes.BOOLEAN()),
- DataTypes.FIELD("f12", DataTypes.BOOLEAN()),
+ DataTypes.FIELD("f11", DataTypes.BOOLEAN().notNull()),
+ DataTypes.FIELD("f12", DataTypes.BOOLEAN().notNull()),
Review Comment:
haven't noticed `f12=null`, by declaring it null, I want to test the case
`and(boolean not null, boolean not null)`. I use another way to test it, so
revert this changes.
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/utils/ScalarOperatorsTestBase.scala:
##########
@@ -67,8 +67,8 @@ abstract class ScalarOperatorsTestBase extends
ExpressionTestBase {
DataTypes.FIELD("f8", DataTypes.INT()),
DataTypes.FIELD("f9", DataTypes.INT()),
DataTypes.FIELD("f10", DataTypes.STRING()),
- DataTypes.FIELD("f11", DataTypes.BOOLEAN()),
- DataTypes.FIELD("f12", DataTypes.BOOLEAN()),
+ DataTypes.FIELD("f11", DataTypes.BOOLEAN().notNull()),
+ DataTypes.FIELD("f12", DataTypes.BOOLEAN().notNull()),
Review Comment:
haven't noticed `f12=null`, by declaring it null, I want to test the case
`and(boolean not null, boolean not null)`. I use another way to test it, so
revert this changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
