[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15455354#comment-15455354
]
ASF GitHub Bot commented on FLINK-3930:
---------------------------------------
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r77171367
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/DefaultCLI.java ---
@@ -77,7 +88,26 @@ public StandaloneClusterClient createCluster(
CommandLine commandLine,
Configuration config) throws
UnsupportedOperationException {
+ // get secure cookie if passed as argument
+ String secureCookieArg =
commandLine.hasOption(CliFrontendParser.SECURE_COOKIE_OPTION.getOpt()) ?
+
commandLine.getOptionValue(CliFrontendParser.SECURE_COOKIE_OPTION.getOpt()) :
null;
+
+ populateSecureCookieConfigurations(config, secureCookieArg);
+
StandaloneClusterDescriptor descriptor = new
StandaloneClusterDescriptor(config);
return descriptor.deploy();
}
-}
+
+ private void populateSecureCookieConfigurations(Configuration config,
String secureCookieArg) {
+
+ boolean securityEnabled =
config.getBoolean(ConfigConstants.SECURITY_ENABLED, DEFAULT_SECURITY_ENABLED);
+ LOG.debug("Security Enabled ? {}", securityEnabled);
--- End diff --
(optional comment)
maybe its a bit nicer to call
```
if(securityEnabled) {
LOG.debug("Security enabled");
} else {
LOG.debug("Security disabled");
}
```
> Implement Service-Level Authorization
> -------------------------------------
>
> Key: FLINK-3930
> URL: https://issues.apache.org/jira/browse/FLINK-3930
> Project: Flink
> Issue Type: New Feature
> Components: Security
> Reporter: Eron Wright
> Assignee: Vijay Srinivasaraghavan
> Labels: security
> Original Estimate: 672h
> Remaining Estimate: 672h
>
> _This issue is part of a series of improvements detailed in the [Secure Data
> Access|https://docs.google.com/document/d/1-GQB6uVOyoaXGwtqwqLV8BHDxWiMO2WnVzBoJ8oPaAs/edit?usp=sharing]
> design doc._
> Service-level authorization is the initial authorization mechanism to ensure
> clients (or servers) connecting to the Flink cluster are authorized to do so.
> The purpose is to prevent a cluster from being used by an unauthorized
> user, whether to execute jobs, disrupt cluster functionality, or gain access
> to secrets stored within the cluster.
> Implement service-level authorization as described in the design doc.
> - Introduce a shared secret cookie
> - Enable Akka security cookie
> - Implement data transfer authentication
> - Secure the web dashboard
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
