shuiqiangchen commented on PR #19958: URL: https://github.com/apache/flink/pull/19958#issuecomment-1159743320
@dianfu Thank you for your suggestions. I have updated the PR accordingly, please have a look. Changes are as followed: - added firstValue and lastValue in BaseExpressions - added first_value and last_value in expression.py. - Reused the existing ITCase. - updated the documentation for System (Built-in) Functions And there is a minor issue , I find that the functions documentation for python is redirect to System (Built-in) Functions documentation for Java API. It's first_value() in python while firstValue() in Java, which seems unaligned that the doc might be a bit misleading. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
