ChengkaiYang2022 commented on code in PR #19964:
URL: https://github.com/apache/flink/pull/19964#discussion_r901132913


##########
docs/content.zh/docs/dev/table/types.md:
##########
@@ -142,56 +142,54 @@ val t: DataType = 
DataTypes.ARRAY(DataTypes.INT().notNull()).bridgedTo(classOf[A
 API is extended. Users of predefined sources/sinks/functions do not need to 
define such hints. Hints within
 a table program (e.g. `field.cast(TIMESTAMP(3).bridgedTo(Timestamp.class))`) 
are ignored.
 
-List of Data Types
+数据类型列表
 ------------------
-
-This section lists all pre-defined data types.
+这部分列举了所有预定义的数据类型。
 {{< tabs "datatypesimport" >}}
 {{< tab "Java/Scala" >}}
-For the JVM-based Table API those types are also available in 
`org.apache.flink.table.api.DataTypes`.
+Java/Scala Table API的数据类型详见: `org.apache.flink.table.api.DataTypes`.
 {{< /tab >}}
 {{< tab "Python" >}}
-For the Python Table API, those types are available in 
`pyflink.table.types.DataTypes`.
+Python Table API, 的数据类型详见: `pyflink.table.types.DataTypes`.
 {{< /tab >}}
 {{< /tabs >}}
 
-The default planner supports the following set of SQL types:
-
-| Data Type        | Remarks for Data Type                              |
-|:-----------------|:---------------------------------------------------|
-| `CHAR`           |                                                    |
-| `VARCHAR`        |                                                    |
-| `STRING`         |                                                    |
-| `BOOLEAN`        |                                                    |
-| `BINARY`         |                                                    |
-| `VARBINARY`      |                                                    |
-| `BYTES`          |                                                    |
-| `DECIMAL`        | Supports fixed precision and scale.                |
-| `TINYINT`        |                                                    |
-| `SMALLINT`       |                                                    |
-| `INTEGER`        |                                                    |
-| `BIGINT`         |                                                    |
-| `FLOAT`          |                                                    |
-| `DOUBLE`         |                                                    |
-| `DATE`           |                                                    |
-| `TIME`           | Supports only a precision of `0`.                  |
-| `TIMESTAMP`      |                                                    |
-| `TIMESTAMP_LTZ`  |                                                    |
-| `INTERVAL`       | Supports only interval of `MONTH` and `SECOND(3)`. |
-| `ARRAY`          |                                                    |
-| `MULTISET`       |                                                    |
-| `MAP`            |                                                    |
-| `ROW`            |                                                    |
-| `RAW`            |                                                    |
-| Structured types | Only exposed in user-defined functions yet.        |
-
-### Character Strings
+默认 `Planner` 支持下列SQL数据类型:
+
+| 数据类型             | 备注                   |
+|:-----------------|:---------------------|
+| `CHAR`           |                      |
+| `VARCHAR`        |                      |
+| `STRING`         |                      |
+| `BOOLEAN`        |                      |
+| `BINARY`         |                      |
+| `VARBINARY`      |                      |
+| `BYTES`          |                      |
+| `DECIMAL`        | 支持固定精度和比例            |

Review Comment:
   Missing '。'?



##########
docs/content.zh/docs/dev/table/types.md:
##########
@@ -205,32 +203,29 @@ CHAR(n)
 DataTypes.CHAR(n)
 ```
 
-**Bridging to JVM Types**
+**JVM Types桥接**
 
-| Java Type                               | Input | Output | Remarks           
       |
-|:----------------------------------------|:-----:|:------:|:-------------------------|
-|`java.lang.String`                       | X     | X      | *Default*         
       |
-|`byte[]`                                 | X     | X      | Assumes UTF-8 
encoding.  |
-|`org.apache.flink.table.data.StringData` | X     | X      | Internal data 
structure. |
+| Java Type                                | 输入 | 输入 | 备注          |
+|:-----------------------------------------|:-----:|:------:|:------------|
+| `java.lang.String`                       |   X   |   X    | *默认*   |
+| `byte[]`                                 |   X   |   X    | 假定 UTF-8 编码 |
+| `org.apache.flink.table.data.StringData` |   X   |   X    | 内部数据结构      |
 
 {{< /tab >}}
 {{< tab "Python" >}}
 ```python
-Not supported.
+Not supported.。

Review Comment:
   Please the using Chinese character here '。' instead of '.'



##########
docs/content.zh/docs/dev/table/types.md:
##########
@@ -386,36 +377,34 @@ NUMERIC(p, s)
 DataTypes.DECIMAL(p, s)
 ```
 
-**Bridging to JVM Types**
+**JVM Types桥接**
 
-| Java Type                                | Input | Output | Remarks          
        |
+| Java Type                                | 输入 | 输出 | 备注                  |
 
|:-----------------------------------------|:-----:|:------:|:-------------------------|
-|`java.math.BigDecimal`                    | X     | X      | *Default*        
        |
-|`org.apache.flink.table.data.DecimalData` | X     | X      | Internal data 
structure. |
+|`java.math.BigDecimal`                    | X     | X      | *默认*             
   |
+|`org.apache.flink.table.data.DecimalData` | X     | X      | 内部数据结构。 |
 
 {{< /tab >}}
 {{< tab "Python" >}}
 ```python
 DataTypes.DECIMAL(p, s)
 ```
 
-<span class="label label-danger">Attention</span> The `precision` and `scale` 
specified in `DataTypes.DECIMAL(p, s)` must be `38` and `18` separately 
currently.
+<span class="label label-danger">请注意</span> 当前, `DataTypes.DECIMAL(p, 
s)`中指定的`precision`和`scale`当前必须分别为`38`和`18`。

Review Comment:
   Please be careful about the space problem.



##########
docs/content.zh/docs/dev/table/types.md:
##########
@@ -142,56 +142,54 @@ val t: DataType = 
DataTypes.ARRAY(DataTypes.INT().notNull()).bridgedTo(classOf[A
 API is extended. Users of predefined sources/sinks/functions do not need to 
define such hints. Hints within
 a table program (e.g. `field.cast(TIMESTAMP(3).bridgedTo(Timestamp.class))`) 
are ignored.
 
-List of Data Types
+数据类型列表
 ------------------
-
-This section lists all pre-defined data types.
+这部分列举了所有预定义的数据类型。
 {{< tabs "datatypesimport" >}}
 {{< tab "Java/Scala" >}}
-For the JVM-based Table API those types are also available in 
`org.apache.flink.table.api.DataTypes`.
+Java/Scala Table API的数据类型详见: `org.apache.flink.table.api.DataTypes`.
 {{< /tab >}}
 {{< tab "Python" >}}
-For the Python Table API, those types are available in 
`pyflink.table.types.DataTypes`.
+Python Table API, 的数据类型详见: `pyflink.table.types.DataTypes`.
 {{< /tab >}}
 {{< /tabs >}}
 
-The default planner supports the following set of SQL types:
-
-| Data Type        | Remarks for Data Type                              |
-|:-----------------|:---------------------------------------------------|
-| `CHAR`           |                                                    |
-| `VARCHAR`        |                                                    |
-| `STRING`         |                                                    |
-| `BOOLEAN`        |                                                    |
-| `BINARY`         |                                                    |
-| `VARBINARY`      |                                                    |
-| `BYTES`          |                                                    |
-| `DECIMAL`        | Supports fixed precision and scale.                |
-| `TINYINT`        |                                                    |
-| `SMALLINT`       |                                                    |
-| `INTEGER`        |                                                    |
-| `BIGINT`         |                                                    |
-| `FLOAT`          |                                                    |
-| `DOUBLE`         |                                                    |
-| `DATE`           |                                                    |
-| `TIME`           | Supports only a precision of `0`.                  |
-| `TIMESTAMP`      |                                                    |
-| `TIMESTAMP_LTZ`  |                                                    |
-| `INTERVAL`       | Supports only interval of `MONTH` and `SECOND(3)`. |
-| `ARRAY`          |                                                    |
-| `MULTISET`       |                                                    |
-| `MAP`            |                                                    |
-| `ROW`            |                                                    |
-| `RAW`            |                                                    |
-| Structured types | Only exposed in user-defined functions yet.        |
-
-### Character Strings
+默认 `Planner` 支持下列SQL数据类型:
+
+| 数据类型             | 备注                   |
+|:-----------------|:---------------------|
+| `CHAR`           |                      |
+| `VARCHAR`        |                      |
+| `STRING`         |                      |
+| `BOOLEAN`        |                      |
+| `BINARY`         |                      |
+| `VARBINARY`      |                      |
+| `BYTES`          |                      |
+| `DECIMAL`        | 支持固定精度和比例            |
+| `TINYINT`        |                      |
+| `SMALLINT`       |                      |
+| `INTEGER`        |                      |
+| `BIGINT`         |                      |
+| `FLOAT`          |                      |
+| `DOUBLE`         |                      |
+| `DATE`           |                      |
+| `TIME`           | 仅支到0.的精度             |
+| `TIMESTAMP`      |                      |
+| `TIMESTAMP_LTZ`  |                      |
+| `INTERVAL`       | 仅支持MONTH 到 SECOND(3) |

Review Comment:
   Please add space between English characters and Chinese characters. And 
please check this kind of problem in the rest section.



##########
docs/content.zh/docs/dev/table/types.md:
##########
@@ -307,15 +300,14 @@ Not supported.
 {{< /tab >}}
 {{< /tabs >}}
 
-The type can be declared using `BINARY(n)` where `n` is the number of bytes. 
`n` must have a value
-between `1` and `2,147,483,647` (both inclusive). If no length is specified, 
`n` is equal to `1`.
+可以使用 `BINARY(n)` 声明该类型,其中 `n` 表示字节数。 `n` 的取值范围为 [`1` , `2,147,483,647` ] 
如果没有指定 `n` 的值, n 等于 1。
 
 
 #### `VARBINARY` / `BYTES`
 
-Data type of a variable-length binary string (=a sequence of bytes).
+可变长度的二进制字符串的数据类型(可以理解为是一种字节序列)

Review Comment:
   Missing '。'



##########
docs/content.zh/docs/dev/table/types.md:
##########
@@ -142,56 +142,54 @@ val t: DataType = 
DataTypes.ARRAY(DataTypes.INT().notNull()).bridgedTo(classOf[A
 API is extended. Users of predefined sources/sinks/functions do not need to 
define such hints. Hints within
 a table program (e.g. `field.cast(TIMESTAMP(3).bridgedTo(Timestamp.class))`) 
are ignored.
 
-List of Data Types
+数据类型列表
 ------------------
-
-This section lists all pre-defined data types.
+这部分列举了所有预定义的数据类型。
 {{< tabs "datatypesimport" >}}
 {{< tab "Java/Scala" >}}
-For the JVM-based Table API those types are also available in 
`org.apache.flink.table.api.DataTypes`.
+Java/Scala Table API的数据类型详见: `org.apache.flink.table.api.DataTypes`.
 {{< /tab >}}
 {{< tab "Python" >}}
-For the Python Table API, those types are available in 
`pyflink.table.types.DataTypes`.
+Python Table API, 的数据类型详见: `pyflink.table.types.DataTypes`.
 {{< /tab >}}
 {{< /tabs >}}
 
-The default planner supports the following set of SQL types:
-
-| Data Type        | Remarks for Data Type                              |
-|:-----------------|:---------------------------------------------------|
-| `CHAR`           |                                                    |
-| `VARCHAR`        |                                                    |
-| `STRING`         |                                                    |
-| `BOOLEAN`        |                                                    |
-| `BINARY`         |                                                    |
-| `VARBINARY`      |                                                    |
-| `BYTES`          |                                                    |
-| `DECIMAL`        | Supports fixed precision and scale.                |
-| `TINYINT`        |                                                    |
-| `SMALLINT`       |                                                    |
-| `INTEGER`        |                                                    |
-| `BIGINT`         |                                                    |
-| `FLOAT`          |                                                    |
-| `DOUBLE`         |                                                    |
-| `DATE`           |                                                    |
-| `TIME`           | Supports only a precision of `0`.                  |
-| `TIMESTAMP`      |                                                    |
-| `TIMESTAMP_LTZ`  |                                                    |
-| `INTERVAL`       | Supports only interval of `MONTH` and `SECOND(3)`. |
-| `ARRAY`          |                                                    |
-| `MULTISET`       |                                                    |
-| `MAP`            |                                                    |
-| `ROW`            |                                                    |
-| `RAW`            |                                                    |
-| Structured types | Only exposed in user-defined functions yet.        |
-
-### Character Strings
+默认 `Planner` 支持下列SQL数据类型:

Review Comment:
   Please add space between [English charater and Chinese 
charate](https://cwiki.apache.org/confluence/display/FLINK/Flink+Translation+Specifications)



##########
docs/content.zh/docs/dev/table/types.md:
##########
@@ -142,56 +142,54 @@ val t: DataType = 
DataTypes.ARRAY(DataTypes.INT().notNull()).bridgedTo(classOf[A
 API is extended. Users of predefined sources/sinks/functions do not need to 
define such hints. Hints within
 a table program (e.g. `field.cast(TIMESTAMP(3).bridgedTo(Timestamp.class))`) 
are ignored.
 
-List of Data Types
+数据类型列表
 ------------------
-
-This section lists all pre-defined data types.
+这部分列举了所有预定义的数据类型。
 {{< tabs "datatypesimport" >}}
 {{< tab "Java/Scala" >}}
-For the JVM-based Table API those types are also available in 
`org.apache.flink.table.api.DataTypes`.
+Java/Scala Table API的数据类型详见: `org.apache.flink.table.api.DataTypes`.
 {{< /tab >}}
 {{< tab "Python" >}}
-For the Python Table API, those types are available in 
`pyflink.table.types.DataTypes`.
+Python Table API, 的数据类型详见: `pyflink.table.types.DataTypes`.
 {{< /tab >}}
 {{< /tabs >}}
 
-The default planner supports the following set of SQL types:
-
-| Data Type        | Remarks for Data Type                              |
-|:-----------------|:---------------------------------------------------|
-| `CHAR`           |                                                    |
-| `VARCHAR`        |                                                    |
-| `STRING`         |                                                    |
-| `BOOLEAN`        |                                                    |
-| `BINARY`         |                                                    |
-| `VARBINARY`      |                                                    |
-| `BYTES`          |                                                    |
-| `DECIMAL`        | Supports fixed precision and scale.                |
-| `TINYINT`        |                                                    |
-| `SMALLINT`       |                                                    |
-| `INTEGER`        |                                                    |
-| `BIGINT`         |                                                    |
-| `FLOAT`          |                                                    |
-| `DOUBLE`         |                                                    |
-| `DATE`           |                                                    |
-| `TIME`           | Supports only a precision of `0`.                  |
-| `TIMESTAMP`      |                                                    |
-| `TIMESTAMP_LTZ`  |                                                    |
-| `INTERVAL`       | Supports only interval of `MONTH` and `SECOND(3)`. |
-| `ARRAY`          |                                                    |
-| `MULTISET`       |                                                    |
-| `MAP`            |                                                    |
-| `ROW`            |                                                    |
-| `RAW`            |                                                    |
-| Structured types | Only exposed in user-defined functions yet.        |
-
-### Character Strings
+默认 `Planner` 支持下列SQL数据类型:
+
+| 数据类型             | 备注                   |
+|:-----------------|:---------------------|
+| `CHAR`           |                      |
+| `VARCHAR`        |                      |
+| `STRING`         |                      |
+| `BOOLEAN`        |                      |
+| `BINARY`         |                      |
+| `VARBINARY`      |                      |
+| `BYTES`          |                      |
+| `DECIMAL`        | 支持固定精度和比例            |
+| `TINYINT`        |                      |
+| `SMALLINT`       |                      |
+| `INTEGER`        |                      |
+| `BIGINT`         |                      |
+| `FLOAT`          |                      |
+| `DOUBLE`         |                      |
+| `DATE`           |                      |
+| `TIME`           | 仅支到0.的精度             |

Review Comment:
   Missing '。'?支持 instead of 支?



##########
docs/content.zh/docs/dev/table/types.md:
##########
@@ -264,22 +259,20 @@ DataTypes.VARCHAR(n)
 DataTypes.STRING()
 ```
 
-<span class="label label-danger">Attention</span> The specified maximum number 
of code points `n` in `DataTypes.VARCHAR(n)` must be `2,147,483,647` currently.
+<span class="label label-danger">请注意</span> 目前,`DataTypes.VARCHAR(n)` 中指定的最大指 
`n` 当前必须为 `2,147,483,647`。

Review Comment:
   值 instead of 指



##########
docs/content.zh/docs/dev/table/types.md:
##########
@@ -638,14 +621,14 @@ DATE
 DataTypes.DATE()
 ```
 
-**Bridging to JVM Types**
+**JVM Types桥接**
 
-| Java Type            | Input | Output | Remarks                              
        |
+| Java Type            | 输入 | 输出 | 备注                                      |
 
|:---------------------|:-----:|:------:|:---------------------------------------------|
-|`java.time.LocalDate` | X     | X      | *Default*                            
        |
+|`java.time.LocalDate` | X     | X      | *默认*                                 
   |
 |`java.sql.Date`       | X     | X      |                                      
        |
-|`java.lang.Integer`   | X     | X      | Describes the number of days since 
epoch.    |
-|`int`                 | X     | (X)    | Describes the number of days since 
epoch.<br>Output only if type is not nullable. |
+|`java.lang.Integer`   | X     | X      | 描述自纪元以来的天数。   |

Review Comment:
   It feels like '纪元' is not a very common term in technical documentation, 
maybe it should be expressed in another term?



##########
docs/content.zh/docs/dev/table/types.md:
##########
@@ -307,15 +300,14 @@ Not supported.
 {{< /tab >}}
 {{< /tabs >}}
 
-The type can be declared using `BINARY(n)` where `n` is the number of bytes. 
`n` must have a value
-between `1` and `2,147,483,647` (both inclusive). If no length is specified, 
`n` is equal to `1`.
+可以使用 `BINARY(n)` 声明该类型,其中 `n` 表示字节数。 `n` 的取值范围为 [`1` , `2,147,483,647` ] 
如果没有指定 `n` 的值, n 等于 1。

Review Comment:
   Missing comma before 如果没有指定 `n` 的值?



##########
docs/content.zh/docs/dev/table/types.md:
##########
@@ -264,22 +259,20 @@ DataTypes.VARCHAR(n)
 DataTypes.STRING()
 ```
 
-<span class="label label-danger">Attention</span> The specified maximum number 
of code points `n` in `DataTypes.VARCHAR(n)` must be `2,147,483,647` currently.
+<span class="label label-danger">请注意</span> 目前,`DataTypes.VARCHAR(n)` 中指定的最大指 
`n` 当前必须为 `2,147,483,647`。
 {{< /tab >}}
 {{< /tabs >}}
 
-The type can be declared using `VARCHAR(n)` where `n` is the maximum number of 
code points. `n` must have a value
-between `1` and `2,147,483,647` (both inclusive). If no length is specified, 
`n` is equal to `1`.
+可以使用 `VARCHAR(n)` 声明该类型,其中 `n` 表示其最大值。`n` 的取值范围为[ `1` , `2,147,483,647` ] 
,如果没有指定 `n` 的值,n 等于 1。

Review Comment:
   How about translating (both inclusive) instead of using '[' and ']' 
characters to let this line more specific?



##########
docs/content.zh/docs/dev/table/types.md:
##########
@@ -614,18 +599,16 @@ DataTypes.DOUBLE()
 {{< /tab >}}
 {{< /tabs >}}
 
-`DOUBLE PRECISION` is a synonym for this type.
+`DOUBLE PRECISION` 是这种类型的同义词。
 
-### Date and Time
+### 日期和时间
 
 #### `DATE`
 
-Data type of a date consisting of `year-month-day` with values ranging from 
`0000-01-01`
-to `9999-12-31`.
-
-Compared to the SQL standard, the range starts at year `0000`.
+日期的数据类型,由 `年-月-日` 组成,取值范围为 `0000-01-01` 到 `9999-12-31` 。

Review Comment:
   When we translate from A to B, maybe we should  only use ' A 到 B' or only 
use 'A ~ B'? 
   It's better to unify the translation method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to