pnowojski commented on code in PR #19993:
URL: https://github.com/apache/flink/pull/19993#discussion_r902363978
##########
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestExecutorImplTest.java:
##########
@@ -128,12 +131,33 @@ public void testIgnoresInterruptsWhileRunning() throws
Exception {
}
}
- @Test
- public void testCanBeClosed() throws IOException {
- TestRequestDispatcher requestProcessor = new TestRequestDispatcher();
+ @Test(timeout = 10000)
Review Comment:
We also have a global test timeout that before killing the process is
printing the thread dump. Our experience shows that timeout test failure due to
a deadlock without stack traces is not helpful at all, so having timeouts on
the unit test level is doing more harm than good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
