XComp commented on code in PR #19907:
URL: https://github.com/apache/flink/pull/19907#discussion_r903346279
##########
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java:
##########
@@ -685,13 +687,27 @@ public CompletableFuture<Acknowledge> submitTask(
jobManagerConnection.getClassLoaderHandle();
PartitionProducerStateChecker partitionStateChecker =
jobManagerConnection.getPartitionStateChecker();
+ TernaryBoolean changelogEnabled = TernaryBoolean.FALSE;
+ try {
+ changelogEnabled =
+ InstantiationUtil.readObjectFromConfig(
+ taskInformation.getTaskConfiguration(),
+ "enablechangelog",
+ getClass().getClassLoader());
Review Comment:
That sounds reasonable in my opinion. Already better than having a
hard-coded String representation here.
I'm just wondering whether config-related stuff should be better of in
`flink-core` which is also a dependency of `flink-stream-java`.
I'd imagine that @zentol might have an opinion here as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
