gyfora commented on code in PR #268:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/268#discussion_r903434917


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/KubernetesOperatorConfigOptions.java:
##########
@@ -203,4 +203,11 @@ public class KubernetesOperatorConfigOptions {
                     .defaultValue(false)
                     .withDescription(
                             "Enables dynamic change of watched/monitored 
namespaces. Defaults to false");
+
+    public static final ConfigOption<Boolean> OPERATOR_JOSDK_METRICS_ENABLED =
+            ConfigOptions.key("kubernetes.operator.josdk.metrics.enabled")
+                    .booleanType()
+                    .defaultValue(true)
+                    .withDescription(
+                            "Enables that Metrics of Java Operator SDK 
forwards metrics to the Flink metric registries . Defaults to true");

Review Comment:
   Please do not include the default value in the description. It will be part 
of the HTML generated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to